Skip to content

sparqls optionals clause can now bind variables. with test. issue 2957 #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

sparqls optionals clause can now bind variables. with test. issue 2957 #3247

merged 3 commits into from
Oct 16, 2025

Conversation

WhiteGobo
Copy link
Contributor

Summary of changes

added test for issue #2957
working patch to fix issue

in technical terms sparql plugin now merges the results of optional with previous results.

also fix mentioned in pr #3077

fix should be backwards compatible

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • If the change has a potential impact on users of this project:
    • Added or updated tests that fail without the change.
    • Updated relevant documentation to avoid inaccuracies.
    • Considered adding additional documentation.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@coveralls
Copy link

Coverage Status

coverage: 90.299%. remained the same
when pulling 756d933 on WhiteGobo:issue2957subselectoptional
into 34751ac on RDFLib:main.

@WhiteGobo WhiteGobo mentioned this pull request Oct 5, 2025
Open
@edmondchuc
Copy link
Contributor

Hi @WhiteGobo, would you like this fix to be included in a v7 release? If so, could you please rebase this onto the 7.x branch?

@WhiteGobo
Copy link
Contributor Author

Eh sure, i just dont know how to do that.

@edmondchuc edmondchuc force-pushed the issue2957subselectoptional branch from 756d933 to a1a9474 Compare October 15, 2025 05:59
@edmondchuc edmondchuc changed the base branch from main to 7.x October 15, 2025 05:59
@edmondchuc
Copy link
Contributor

@WhiteGobo I've rebased your commits onto 7.x now. I'm going to close and re-open the PR to re-trigger the pre-commit.ci.

@edmondchuc edmondchuc closed this Oct 15, 2025
@edmondchuc edmondchuc reopened this Oct 15, 2025
@floresbakker
Copy link

floresbakker commented Oct 15, 2025 •
edited
Loading

Just an expression of gratitude to @WhiteGobo. Man, if this gets released I will be very happy. So many projects of mine are dependent on the solution to this bug. Many thanks for your efforts and for taking over my pull request. Is there any sight of a release date already?

...and to @edmondchuc as well, thx!

@edmondchuc
Copy link
Contributor

Thanks for this PR and both your contributions @floresbakker @WhiteGobo. I will be merging this today and look to make a v7 release very soon.

I am not familiar with the sparql plugin code at all, so I thank you both for providing a test that shows the fix.

@edmondchuc edmondchuc merged commit 32b6b88 into RDFLib:7.x Oct 16, 2025
20 checks passed
@edmondchuc edmondchuc mentioned this pull request Oct 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WhiteGobo @coveralls @edmondchuc @floresbakker